Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement backoff strategy #35

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Implement backoff strategy #35

merged 7 commits into from
Apr 18, 2024

Conversation

tonykchen
Copy link
Contributor

@tonykchen tonykchen commented Apr 16, 2024

Issue #, if available:
Closes #16

Description of changes:

  • Moved common boto3 client logic to utils
  • Added adaptive retry as documented here: https://boto3.amazonaws.com/v1/documentation/api/latest/guide/retries.htm
  • Added max_retry config to docs
  • Added file headers to all .py files under src/
  • Updated distribution name to agent-evaluation (pip install agent-evaluation)
  • Added MANIFEST.in and long_description_content_type in setup.py to fix twine upload issues.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tonykchen tonykchen marked this pull request as ready for review April 16, 2024 23:20
Copy link
Contributor

@bobbywlindsey bobbywlindsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobbywlindsey bobbywlindsey merged commit 60c43f8 into main Apr 18, 2024
4 checks passed
@bobbywlindsey bobbywlindsey deleted the implement-backoff branch April 18, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add backoff strategy for evaluators and targets
2 participants