Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java (v2): DynamoDB - Add PartiQL batch select example. #7090

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Java (v2): DynamoDB - Add PartiQL batch select example. #7090

merged 3 commits into from
Nov 20, 2024

Conversation

scmacdon
Copy link
Contributor

@scmacdon scmacdon commented Nov 20, 2024 •
edited
Loading

This pull request updates a DynamoDB example to address a ticket. It adds a new method that shows use of Select statements using Batch. It also places the scenario examples into a seperate package.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@scmacdon scmacdon added Java-v2 This issue relates to the AWS SDK for Java V2 Bug An update to fix incorrect code or typos. labels Nov 20, 2024
@scmacdon scmacdon self-assigned this Nov 20, 2024
cpyle0819
cpyle0819 requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@cpyle0819 cpyle0819 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few change requests. Also, the PR title and description are not informative enough. Please describe the actual problem being addressed instead of referencing a generic ticket.

javav2/example_code/dynamodb/src/main/java/com/example/dynamodb/ScenarioPartiQLBatch.java Outdated Show resolved Hide resolved
javav2/example_code/dynamodb/src/main/java/com/example/dynamodb/ScenarioPartiQLBatch.java Outdated Show resolved Hide resolved
javav2/example_code/dynamodb/src/main/java/com/example/dynamodb/ScenarioPartiQLBatch.java Outdated Show resolved Hide resolved
@cpyle0819 cpyle0819 changed the title This PR updates a DynamoDB example to address a tic Java (v2): DynamoDB - Add PartiQL batch select example. Nov 20, 2024
@scmacdon scmacdon added the On Call Review needed This work needs an on-call review label Nov 20, 2024
@Laren-AWS Laren-AWS added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Nov 20, 2024
@Laren-AWS Laren-AWS merged commit b6fab98 into awsdocs:main Nov 20, 2024
15 checks passed
@scmacdon scmacdon deleted the dynamodb branch November 26, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpyle0819 cpyle0819 cpyle0819 approved these changes

Assignees

@scmacdon scmacdon

Labels
Bug An update to fix incorrect code or typos. Java-v2 This issue relates to the AWS SDK for Java V2 On Call Review complete On call review complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scmacdon @cpyle0819 @Laren-AWS