Go: Update all bucket name uses to user input, env vars, or approved names. #6970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laren-AWS
added
On Call Review needed
Laren-AWS
requested review from
a team and
scmacdon
and removed request for
a team
DavidSouther
added
On Call Review complete
DavidSouther
force-pushed
the
go-example-buckets
branch
from
561bd12
to
b1cb814
Compare
DavidSouther
approved these changes
Oct 9, 2024
scmacdon
reviewed
Oct 9, 2024
| @@ -149,7 +149,7 @@ var ( | |||
| // and config files. | |||
| func main() { | |||
|
|
|||
| flag.StringVar(&bucketName, "bucket", "", "<EXAMPLE-BUCKET-NAME>") | |||
| flag.StringVar(&bucketName, "bucket", "", "amzn-s3-demo-bucket") | |||
There was a problem hiding this comment.
that looks good. Entire PR looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.