-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools - Weathertop: Update plugin stacks to include EnvVars #6948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Tools
This issue relates to a custom tooling to streamline development tasks
label
Oct 2, 2024
ford-at-aws
changed the title
Update Weathertop to include env Vars
Tools - Weathertop: Update plugin stacks to include env Vars
Oct 2, 2024
ford-at-aws
changed the title
Tools - Weathertop: Update plugin stacks to include env Vars
Tools - Weathertop: Update plugin stacks to include EnvVars
Oct 2, 2024
ford-at-aws
added
the
Task
A general update to the code base for language clarification, missing actions, tests, etc.
label
Oct 2, 2024
cpyle0819
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommending creating a variables.json
file that can be read, parsed, and passed directly to the batch env vars instead of doing the extra processing.
cpyle0819
reviewed
Oct 8, 2024
cpyle0819
requested changes
Oct 8, 2024
DavidSouther
reviewed
Oct 8, 2024
DavidSouther
reviewed
Oct 9, 2024
cpyle0819
approved these changes
Oct 9, 2024
DavidSouther
added
On Call Review complete
On call review complete
and removed
On Call Review needed
This work needs an on-call review
labels
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
On Call Review complete
On call review complete
Task
A general update to the code base for language clarification, missing actions, tests, etc.
Tools
This issue relates to a custom tooling to streamline development tasks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all Weathertop plugin stacks so that a new environment variable is available as a part of all Job Definitions.
NOTE: As part of testing, this change has been deployed to all plugin environments.
Docs on using custom EnvVars in AWS Batch Fargate using ContainerProperties
Here is an example of the new Job Def, presented here in JSON format bc the EnvVar is not visible in the Console: