Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift: S3 update #6890

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

meyertst-aws
Copy link
Contributor

Replace exit with throw.
Remove hard-coded regions.
Add pagination.
Log errors.
Swift formatting.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@meyertst-aws meyertst-aws added Swift This issue relates to the AWS SDK for Swift Task A general update to the code base for language clarification, missing actions, tests, etc. labels Sep 20, 2024
@meyertst-aws meyertst-aws self-assigned this Sep 20, 2024
Copy link
Contributor

@shepazon shepazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@meyertst-aws meyertst-aws added the On Call Review needed This work needs an on-call review label Sep 20, 2024
@scmacdon scmacdon added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Sep 20, 2024
@Laren-AWS Laren-AWS merged commit 376c52a into awsdocs:main Sep 23, 2024
14 checks passed
@meyertst-aws meyertst-aws deleted the swift_update_remaining_s3 branch October 21, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Call Review complete On call review complete Swift This issue relates to the AWS SDK for Swift Task A general update to the code base for language clarification, missing actions, tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants