Skip to content

Commit

Permalink
feature: add Python 3.7 support (#168)
Browse files Browse the repository at this point in the history
* update setup.py with latest version of sagemaker-training

* test against py37 and parallelize unit tests

* add coveragerc file
  • Loading branch information
ajaykarpur authored May 6, 2020
1 parent 196d663 commit d60a3dc
Show file tree
Hide file tree
Showing 5 changed files with 26 additions and 5 deletions.
20 changes: 20 additions & 0 deletions .coveragerc_py37
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
[run]
branch = True
timid = True

[report]
exclude_lines =
pragma: no cover
pragma: py3 no cover
if six.PY2
elif six.PY2

partial_branches =
pragma: no cover
pragma: py3 no cover
if six.PY3
elif six.PY3

show_missing = True

fail_under = 90
2 changes: 1 addition & 1 deletion buildspec-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ phases:
# run unit tests
- AWS_ACCESS_KEY_ID= AWS_SECRET_ACCESS_KEY= AWS_SESSION_TOKEN=
AWS_CONTAINER_CREDENTIALS_RELATIVE_URI= AWS_DEFAULT_REGION=
tox -e py27,py36 -- test/unit
tox -e py27,py36,py37 --parallel all -- test/unit

# run local integ tests
#- $(aws ecr get-login --no-include-email --region us-west-2)
Expand Down
2 changes: 1 addition & 1 deletion buildspec-toolkit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ phases:
- tox -e flake8,twine

# run unit tests
- tox -e py36,py27 test-toolkit/unit
- tox -e py27,py36,py37 --parallel all -- test/unit

# define tags
- GENERIC_CPU_TAG="$FRAMEWORK_VERSION-mxnet-cpu-$BUILD_ID"
Expand Down
5 changes: 3 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,13 @@ def read(fname):
"License :: OSI Approved :: Apache Software License",
"Programming Language :: Python",
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
],

# We don't declare our dependency on mxnet here because we build with
# different packages for different variants (e.g. mxnet-mkl and mxnet-cu90).
install_requires=['sagemaker-training>=3.4.2', 'retrying==1.3.3'],
install_requires=['sagemaker-training>=3.5.0', 'retrying==1.3.3'],
extras_require={
'test': test_dependencies
},
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# test suite on all supported python versions. To use it, "pip install tox"
# and then run "tox" from this directory.
[tox]
envlist = py27,py36,flake8,twine
envlist = py27,py36,py37,flake8,twine
skip_missing_interpreters = False

[travis]
Expand Down

0 comments on commit d60a3dc

Please sign in to comment.