Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal Review] updating messages in logs for transform #494

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Internal Review] updating messages in logs for transform #494

wants to merge 2 commits into from

Conversation

pranav-firake
Copy link
Contributor

Problem

Updating log messages so that they are more consistent

Solution

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pranav-firake pranav-firake requested review from a team as code owners October 11, 2024 02:16
@pranav-firake pranav-firake changed the title updating messages in logs for transform [Internal Review] updating messages in logs for transform Oct 11, 2024
jonlouie
jonlouie requested changes Oct 11, 2024
View reviewed changes
server/aws-lsp-codewhisperer/src/language-server/netTransform/transformHandler.ts Show resolved Hide resolved
server/aws-lsp-codewhisperer/src/language-server/netTransform/transformHandler.ts Show resolved Hide resolved
server/aws-lsp-codewhisperer/src/language-server/netTransform/transformHandler.ts Show resolved Hide resolved
server/aws-lsp-codewhisperer/src/language-server/netTransform/transformHandler.ts Show resolved Hide resolved
server/aws-lsp-codewhisperer/src/language-server/netTransform/transformHandler.ts Show resolved Hide resolved
server/aws-lsp-codewhisperer/src/language-server/netTransform/transformHandler.ts Show resolved Hide resolved
server/aws-lsp-codewhisperer/src/language-server/netTransformServer.ts Show resolved Hide resolved
@jonlouie jonlouie self-requested a review October 11, 2024 15:21
@jonlouie
Copy link

Spoke offline with @pranav-firake and we will take a deeper look at the log messages themselves at another time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huawenm huawenm huawenm approved these changes

@jonlouie jonlouie Awaiting requested review from jonlouie

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pranav-firake @jonlouie @huawenm