Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filtered entities #741

Closed
wants to merge 7 commits into from
Closed

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Jan 11, 2025

Description

My last PR #739 was slightly incorrect in its approach. After some further testing I now understand how it should work.

  • Hiding entities from the table view (by ID) makes the entity invisible in the graph, but it still exists taking up space
  • Filtering entity types from the sidebar removes the matching entities from the graph so that they do not take up space in the graph and it forces a graph layout

So I've updated the logic to work the correct way.

Other changes

  • Removed duplicate recoil state for filtered entities and fixed references
  • Simplified useEntities again by updating the get part of entitiesSelector

Validation

  • Verified all filtering and hiding logic

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review January 11, 2025 01:31
@andreachild
Copy link

LGTM

@kmcginnes
Copy link
Collaborator Author

Update

After speaking with the rest of the team, we have decided to have both the filter sidebar and the graph table behave the same. They will both remove the entity from rendering in a way that does not reserve space.

This PR will need to be updated to reflect this new behavior.

@kmcginnes kmcginnes marked this pull request as draft January 14, 2025 17:11
@kmcginnes kmcginnes force-pushed the remove-filtered-entities branch from c45d711 to fab6add Compare January 14, 2025 21:20
@kmcginnes
Copy link
Collaborator Author

Closing this PR to open a new one with a better description of the changes

@kmcginnes kmcginnes closed this Jan 14, 2025
@kmcginnes kmcginnes deleted the remove-filtered-entities branch January 14, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update hiding logic to remove entities from rendering
2 participants