Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use common pod selector in metrics service #24

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

taraspos
Copy link
Contributor

@taraspos taraspos commented Sep 30, 2024

Issue #, if available:

Description of changes:

Currently metrics service selector doesn't work, because it uses label app which is NOT assigned to pods.
This change will use {{- include "eks-pod-identity-agent.selectorLabels" . | nindent 4 }} instead, same as daemon set does.

Code refernces:


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@taraspos taraspos marked this pull request as ready for review September 30, 2024 16:58
@taraspos taraspos requested a review from a team as a code owner September 30, 2024 16:58
@taraspos taraspos changed the title fix: fix metrics service selector fix: use common pod selector in metrics service Sep 30, 2024
@taraspos
Copy link
Contributor Author

@micahhausler @kmala would appreciate if you could take a look at this one as well :)

@kmala kmala merged commit 310f4c1 into aws:main Oct 1, 2024
@taraspos taraspos deleted the patch-3 branch October 2, 2024 14:10
taraspos pushed a commit to gravitational/eks-pod-identity-agent that referenced this pull request Oct 18, 2024
`eks-pod-identiy-agent` -> `eks-pod-identity-agent`

fix: fix metrics service selector (aws#24)

fix: tidy go mods to fix vendoring (aws#25)

Update app label value (aws#28)

`eks-pod-identiy-agent` -> `eks-pod-identity-agent`

Initial service account fetcher logic

Add `kubernetes.io` parsing logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants