fix: use common pod selector in metrics service #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Currently metrics service selector doesn't work, because it uses label
app
which is NOT assigned to pods.This change will use
{{- include "eks-pod-identity-agent.selectorLabels" . | nindent 4 }}
instead, same as daemon set does.Code refernces:
eks-pod-identity-agent/charts/eks-pod-identity-agent/templates/daemonset.yaml
Lines 11 to 18 in af723f6
eks-pod-identity-agent/charts/eks-pod-identity-agent/templates/_helpers.tpl
Lines 46 to 52 in af723f6
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.