feat: Add prometheus endpoint #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @pkruk for the contribution. The approach looks good and i can take a look once you have the changes ready. |
|
thanks! I will then continue my work and let you know! |
pkruk
changed the title
|
I added two more metrics and I tested it locally in one of our test clusters. I will be very happy to hear feedback :)! |
pkruk
commented
Sep 19, 2024
kmala
reviewed
Sep 19, 2024
| Name: "pod_identity_cache_non_recoverable_error", | ||
| Help: "Removing credentials from cache, got non recoverable error", | ||
| }) | ||
| promCacheHit = promauto.NewCounterVec(prometheus.CounterOpts{ |
There was a problem hiding this comment.
nit: would suggest to rename to promCacheState as one of the state is hit?
| @@ -52,6 +54,18 @@ type internalClock func() time.Time | |||
| // type assertion | |||
| var _ credentials.CredentialRetriever = &cachedCredentialRetriever{} | |||
|
|
|||
| var ( | |||
| promCacheNonRecoverableError = promauto.NewCounter(prometheus.CounterOpts{ | |||
There was a problem hiding this comment.
i think we can just keep this as pod_identity_cache_errors and may be we might want to capture both recoverable and non-recoverable errors.
|
kmala
approved these changes
Sep 19, 2024
|
@pkruk thanks for the contribution |
|
thank you :)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #13 ,
Description of changes:
I’m currently missing a metrics endpoint in the pod-identity-agent, which is essential for creating alerts and dashboards. I was wondering if you would consider supporting a Prometheus endpoint for this purpose.
I started working on implementing in eks-pod-identity-code but I would like to ask you for your opinion, before I will start implementing more metrics and logic :)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.