Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pdb for appmesh controller #982

Closed
wants to merge 2 commits into from

Conversation

brandocomando
Copy link

Issue

Description of changes

Update PDB to be compatible with k8s 1.27+

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

Deploy helm chart on k8s cluster 1.27+ where pdb poilcy/v1beta1 has been deprecated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brandocomando brandocomando requested a review from a team as a code owner August 14, 2023 15:34
@ysdongAmazon
Copy link
Collaborator

https://github.com/aws/aws-app-mesh-controller-for-k8s/pull/470/files

An inconsistency with our controller repo, thanks for finding out. Should be good to merge. @BennettJames

@BennettJames
Copy link
Contributor

Hey Brandon,

Thanks for the PR. The files you are modifying here are coming from a different location - they originate in https://github.com/aws/aws-app-mesh-controller-for-k8s/blob/master/config/helm/appmesh-controller/templates/pdb.yaml#L4, and will need to be modified there for this change to stick.

@brandocomando
Copy link
Author

Thanks for pointing that out. Opened a PR over there: aws/aws-app-mesh-controller-for-k8s#723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants