[appmesh-prometheus] Add support for remote-write #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BennettJames
approved these changes
Aug 1, 2023
|
Hey egkelly, thanks for submitting a patch. This looks pretty low risk, so I've approved and merged it. |
|
Thanks for the speedy PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#977
Description of changes
Add optional configuration for prometheus remote-write according to documentation for Prometheus v2.13. This will need to be changed when the chart installs Prometheus >= 2.26
Checklist
README.mdfor modified charts)versioninChart.yamlfor the modified chart(s)Testing
Manually added the remote_write configuration with URL and bearer token directly to a running configuration of appmesh-prometheus and verified successful remote writing to (in my case) NewRelic.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.