Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda): removed delete action for lambda and s3 in AppBuilder #5922

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

seshubaws
Copy link
Contributor

Problem

When resources are provisioned and controlled through a SAM template, customers should never modify resources directly as this such action would create drift in the CFN template.

Solution

Removed action to delete a Lambda or S3 bucket in the AppBuilder section


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@seshubaws seshubaws requested a review from a team as a code owner November 4, 2024 20:35
Copy link

github-actions bot commented Nov 4, 2024

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@hayemaxi
Copy link
Contributor

hayemaxi commented Nov 4, 2024

When resources are provisioned and controlled through a SAM template, customers should never modify resources directly as this such action would create drift in the CFN template.

Is the information presented to the user somehow? Might be worth telling them why they can't delete it.

@hayemaxi
Copy link
Contributor

hayemaxi commented Nov 4, 2024

This seems like it needs a changelog item, please see the github bot comment.

@seshubaws
Copy link
Contributor Author

Is the information presented to the user somehow? Might be worth telling them why they can't delete it.

@hayemaxi Do you know if there is a good place to do that?

@justinmk3
Copy link
Contributor

justinmk3 commented Nov 5, 2024

Closes #502 ?

@justinmk3 justinmk3 merged commit 7f4517d into aws:master Nov 5, 2024
23 of 25 checks passed
@seshubaws seshubaws deleted the fix/remove-delete-action branch November 5, 2024 20:54
@seshubaws
Copy link
Contributor Author

Closes #502 ?

Unfortunately no, this PR only removes the delete action from resources in the AppBuilder. I believe #502 is referring to removing the delete action for Lambda functions in the Explorer section that belong to CFN stacks. We will prioritize working on #502

@hayemaxi
Copy link
Contributor

hayemaxi commented Nov 5, 2024

Is the information presented to the user somehow? Might be worth telling them why they can't delete it.

@hayemaxi Do you know if there is a good place to do that?

Not sure, just something to consider. Maybe keep the option but have it grayed out with a tooltip that says why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants