Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: user agent 2.1 #3001

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

enhancement: user agent 2.1 #3001

wants to merge 5 commits into from

Commits on Nov 21, 2024

  1. enhancement: user agent 2.1 

    This change provides:
- A builder class for appending metrics
- Default initialization of a metrics builder within command instantiation
- Wraps user agent logic into a single middleware class
- Adds middlewares into the different features from where metrics can be gather, to acomplish this purpose.
    @yenfryherrerafeliz
    yenfryherrerafeliz committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    8e49c6f View commit details
    Browse the repository at this point in the history

  2. feat: user agent v2.1 second revision 

    - Move the user agent middleware after the signing step in order to gather signature metrics.
- Add request compression metric gathering.
- Add specific testing for signatures.
- Add specific testing for request compression.
- Add specific testing for s3 encryption clients.
- Add credentials metric gathering logic.
- Add tests for credentials metrics.
- Make existent credentials tests to work with the new field `source`. For example, for tests around profile credentials the source property for credentials MUST be `profile`. The default value for this field is `static`.
    @yenfryherrerafeliz
    yenfryherrerafeliz committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    f083085 View commit details
    Browse the repository at this point in the history

  3. chore: address PR feedback 

    - Use static mapping instead of multiple if/else-ifs.
- Remove the endpoint_id metric tracking since it was removed from the spec.
- Make method's name to be verb based.
- Remove the getMetricsBuilder from the CommandInterface.
    @yenfryherrerafeliz
    yenfryherrerafeliz committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    3600657 View commit details
    Browse the repository at this point in the history

  4. chore: add credentials->source tests 

    - Add tests cases to cover credentials sets the correct source when resolved.
- Fix the sso, sso_legacy, and process metrics. They should be all a profile based metric.
    @yenfryherrerafeliz
    yenfryherrerafeliz committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    b8ab573 View commit details
    Browse the repository at this point in the history

  5. chore: add missing blank lines

    @yenfryherrerafeliz
    yenfryherrerafeliz committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    eb1aa90 View commit details
    Browse the repository at this point in the history