Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Observability to Data Model Operations is DynamoDB HLL #3492

Open
wants to merge 5 commits into
base: feature/observability-ddb
Choose a base branch
from

Conversation

96malhar
Copy link
Contributor

@96malhar 96malhar commented Sep 30, 2024

Description

This PR adds observability to Data Model operations is DynamoDB HLL by creating traces using the SDK observability APIs.

  • Traces are only created for public APIs that make a network call.
  • I have updated the Async public APIs to await the Task instead of returning it. This is done to ensure that the trace is not disposed before the function completes its execution.

Motivation and Context

This change is required as part of the Observability initiative for the SDK and HLLs
DOTNET-7679

Testing

  • All existing Unit and Integrations tests pass locally
  • Pending a full dry-run. Since I am targeting a feature branch, I'll perform a full dry run on the feature branch itself after observability updates are merged in for both the data model and document model operations

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant