fix(evenstream-handler-node): add system clock offset to event signing streams #6227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
fix/stream-clock-offset
branch
3 times, most recently
from
1745389
to
79ef154
Compare
kuhe
commented
Jun 26, 2024
|
|
||
| constructor(options: EventStreamPayloadHandlerOptions) { | ||
| this.messageSigner = options.messageSigner; | ||
| this.eventStreamCodec = new EventStreamCodec(options.utf8Encoder, options.utf8Decoder); | ||
| this.systemClockOffsetProvider = async () => options.systemClockOffset ?? 0; |
There was a problem hiding this comment.
the offset is converted to a provider because the offset must be read at the time of signing and not at the time of initialization.
the offset may have been corrected at some point in the client lifecycle, necessitating a live check of the number value.
There was a problem hiding this comment.
this won't work immediately because during config resolution we keep copying the object for whatever reason
kuhe
force-pushed
the
fix/stream-clock-offset
branch
from
79ef154
to
6a6d2e2
Compare
siddsriv
approved these changes
Jun 26, 2024
trivikr
approved these changes
Jun 26, 2024
3 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #6217
Description
Add system clock offset to dates in event signing streams
Testing
manual testing with https://github.com/esauerbo/rekognition-sdk-repro/tree/clockSkew, updated unit tests