feat(deadline): add ability to import repository settings #395
Conversation
jericht
force-pushed
the
jericht/repository_configuration
branch
from
b46c83d
to
3079965
Compare
|
General question... do we want to be doing this via Deadline's Repository installer? We have the ability to hit RCS endpoints in our Lambdas now, so we could do up a CustomResource that imports Repository settings. I suppose the two are not mutually exclusive... it makes sense to have the ability to import settings to the repository during an initial installation of the repository, but it also may be desirable to be able to programmatically build out repository settings JSON from deployed infrastructure and import those settings post-Repository-install. |
| REPOSITORY_SETTINGS_ARG_STRING='' | ||
| if [ ! -z "$DEADLINE_REPOSITORY_SETTINGS_FILE" ]; then | ||
| if [ ! -f "$DEADLINE_REPOSITORY_SETTINGS_FILE" ]; then | ||
| echo "WARNING: Repository settings file was specified but is not a file: $DEADLINE_REPOSITORY_SETTINGS_FILE. Repository settings will not be imported." |
There was a problem hiding this comment.
I wonder if we should make this case a fail. The warning's in the logs, but it looks like a successful deploy from the CDK CLI (and CloudFormation), but the customer would only know it's a fail if they look at the repository's cloud-init logs.
There was a problem hiding this comment.
That's a good point, changed this to fail the script
| * The Deadline Repository settings file to import. | ||
| * @see https://docs.thinkboxsoftware.com/products/deadline/10.1/1_User%20Manual/manual/repository-settings-importer-exporter.html | ||
| */ | ||
| readonly repositorySettings?: Asset; |
There was a problem hiding this comment.
We should describe the default behaviour here too.
| @@ -887,7 +897,8 @@ export class Repository extends Construct implements IRepository { | |||
| private configureRepositoryInstallerScript( | |||
| installerGroup: AutoScalingGroup, | |||
| installPath: string, | |||
| version: IVersion) { | |||
| version: IVersion, | |||
| settings?: Asset) { | |||
There was a problem hiding this comment.
The closing parenthasis shoud be on a new line and the settings line should have a comma dangle.
Partial fix for #397
Notes
Adds ability to import Deadline Repository settings with a repository settings file (see https://docs.thinkboxsoftware.com/products/deadline/10.1/1_User%20Manual/manual/repository-settings-importer-exporter.html)
Testing
Creating a JSON file that conformed to the repository settings importer format with a region and a path mapping rule. Modified the example app to use the file in the
Repositoryconstruct and deployed it. Verified that:ExportRepositorySettingsDeadline command from theRenderQueuecontainer and verified the settings I imported were in the outputAlso deployed without the settings and verified the installer still succeeds.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license