Refactor logic in _is_node_in_replacement_valid() to account for node.instance being None
#620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-3.9 #620 +/- ##
============================================
Coverage 90.78% 90.78%
============================================
Files 20 20
Lines 3135 3137 +2
============================================
+ Hits 2846 2848 +2
Misses 289 289
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dreambeyondorange
force-pushed
the
backing_instance_timeout
branch
2 times, most recently
from
bf18615
to
19e3106
Compare
dreambeyondorange
changed the title
_is_node_in_replacement_valid to account for node.instance being None_is_node_in_replacement_valid() to account for node.instance being None
dreambeyondorange
force-pushed
the
backing_instance_timeout
branch
from
19e3106
to
58913aa
Compare
hanwen-pcluste
previously approved these changes
Mar 1, 2024
…ode.instance` being `None`
dreambeyondorange
force-pushed
the
backing_instance_timeout
branch
from
58913aa
to
a8ca0e1
Compare
hanwen-pcluste
approved these changes
Mar 1, 2024
dreambeyondorange
added a commit
that referenced
this pull request
Mar 1, 2024
…nt_valid()`, `is_backing_instance_valid()`, and unit tests (#622) * Add logic to `is_backing_instance_valid()` to check the IP to make sure the instance matches what is being tracked (#618) The missing instance map did not track what the IP address was that was associated with the slurm node. Because of this if a new instance is launched before an instance becomes healthy, the increment is not reset for the instance count map. This change uses a class object to track the data and links the node name to the ip. Also use the `is_backing_instance_valid()` function in `is_state_healthy()` instead of the plain `node.instance` object check to allow for the delay in EC2 consistency. * Refactor logic in `_is_node_in_replacement_valid()` to account for `node.instance` being `None` (#620) * Add unit tests to cover max_count > 0 in _is_node_in_replacement_valid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.