Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ec2_instance_missing_max_count default to 0, to match behavior before the option was added. #617

Merged

Conversation

dreambeyondorange
Copy link
Contributor

Tests

  • Ran unit tests and integration test for test_slurm_protected_mode locally to ensure success

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dreambeyondorange dreambeyondorange changed the title Set backing_instance_max_count default to 0, to match behavior before the option was added. Set ec2_instance_missing_max_count default to 0, to match behavior before the option was added. Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.77%. Comparing base (29e65f6) to head (86e7920).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #617   +/-   ##
========================================
  Coverage    90.77%   90.77%           
========================================
  Files           20       20           
  Lines         3123     3123           
========================================
  Hits          2835     2835           
  Misses         288      288           
Flag Coverage Δ
unittests 90.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dreambeyondorange dreambeyondorange merged commit 293efb7 into aws:develop Feb 27, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants