Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test, DRAFT] variant of get_ciphers #2124

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

smittals2
Copy link
Contributor

Issues:

Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2

Description of changes:

Describe AWS-LC’s current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@smittals2 smittals2 requested a review from a team as a code owner January 17, 2025 01:35
@smittals2 smittals2 marked this pull request as draft January 17, 2025 01:36
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 74.77477% with 28 lines in your changes missing coverage. Please review.

Project coverage is 78.93%. Comparing base (6aa30a9) to head (7fda86e).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
ssl/handshake_client.cc 36.36% 13 Missing and 1 partial ⚠️
ssl/ssl_test.cc 78.78% 6 Missing and 1 partial ⚠️
ssl/ssl_cipher.cc 86.36% 6 Missing ⚠️
ssl/ssl_lib.cc 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2124      +/-   ##
==========================================
+ Coverage   78.75%   78.93%   +0.17%     
==========================================
  Files         598      610      +12     
  Lines      103653   105212    +1559     
  Branches    14720    14917     +197     
==========================================
+ Hits        81634    83046    +1412     
- Misses      21365    21512     +147     
  Partials      654      654              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants