Address Scrutinice findings #2121
Merged
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
force-pushed
the
scrutinice-2025-01-15
branch
from
09645e3 to
74910e3
Compare
smittals2
previously approved these changes
Jan 15, 2025
WillChilds-Klein
previously approved these changes
Jan 15, 2025
justsmth
dismissed stale reviews from WillChilds-Klein and smittals2
via
3924c67
jakemas
reviewed
Jan 15, 2025
There was a problem hiding this comment.
free_der.reset(der) is still used in a few more spots:
aws-lc/crypto/evp_extra/evp_extra_test.cc
Line 1622 in d04c818
aws-lc/crypto/evp_extra/evp_extra_test.cc
Line 1629 in d04c818
aws-lc/crypto/x509/x509_test.cc
Line 7503 in d04c818
WillChilds-Klein
previously approved these changes
Jan 15, 2025
justsmth
force-pushed
the
scrutinice-2025-01-15
branch
from
4c242e2 to
06f297c
Compare
WillChilds-Klein
approved these changes
Jan 15, 2025
smittals2
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses P188794065
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.