Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCRUTINICE fixes #2103

Merged
merged 6 commits into from
Jan 15, 2025
Merged

SCRUTINICE fixes #2103

merged 6 commits into from
Jan 15, 2025

Conversation

smittals2
Copy link
Contributor

@smittals2 smittals2 commented Jan 10, 2025

Issues:

Description of changes:

  • Removal of some dead code
  • Casting work arounds

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@smittals2 smittals2 requested a review from a team as a code owner January 10, 2025 01:53
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 78.91%. Comparing base (c826c21) to head (2d0caf7).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
crypto/bio/bio.c 62.50% 12 Missing ⚠️
crypto/bn_extra/convert.c 50.00% 3 Missing ⚠️
crypto/bio/hexdump.c 0.00% 2 Missing ⚠️
crypto/fipsmodule/modes/cbc.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2103      +/-   ##
==========================================
+ Coverage   78.76%   78.91%   +0.15%     
==========================================
  Files         598      610      +12     
  Lines      103656   105133    +1477     
  Branches    14720    14910     +190     
==========================================
+ Hits        81641    82969    +1328     
- Misses      21363    21510     +147     
- Partials      652      654       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crypto/bio/bio.c Outdated Show resolved Hide resolved
crypto/bio/bio.c Outdated Show resolved Hide resolved
crypto/bn_extra/convert.c Outdated Show resolved Hide resolved
crypto/fipsmodule/modes/cbc.c Outdated Show resolved Hide resolved
@smittals2 smittals2 changed the title Adding unsigned int sanitization and SCRUTINICE fixes SCRUTINICE fixes Jan 13, 2025
crypto/bn_extra/convert.c Outdated Show resolved Hide resolved
@smittals2 smittals2 requested a review from justsmth January 13, 2025 23:00
@smittals2 smittals2 merged commit 13a330b into aws:main Jan 15, 2025
125 of 126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants