Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more logging for SSL_ERROR_SYSCALL errors in bssl_shim.cc #2079

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Add more logging for SSL_ERROR_SYSCALL errors in bssl_shim.cc #2079

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afd0b38
Add more logging for SSL_ERROR_SYSCALL errors in bssl_shim.cc
andrewhop Dec 24, 2024
924db9d
Use c strerror not c++ std::strerror
andrewhop Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ssl/test/bssl_shim.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ OPENSSL_MSVC_PRAGMA(warning(pop))
#endif

#include <assert.h>
#include <errno.h>

#ifndef __STDC_FORMAT_MACROS
#define __STDC_FORMAT_MACROS
Expand Down Expand Up @@ -986,6 +987,11 @@ static bool DoConnection(bssl::UniquePtr<SSL_SESSION> *out_session,
int ssl_err = SSL_get_error(ssl.get(), -1);
if (ssl_err != SSL_ERROR_NONE) {
fprintf(stderr, "SSL error: %s\n", SSL_error_description(ssl_err));
if (ssl_err == SSL_ERROR_SYSCALL) {
int err = errno;
fprintf(stderr, "Error occurred: errno = %d, description = %s\n", err, strerror(err));

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np: extra line

}
}
return false;
}
Expand Down
Loading