Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes varios issues with rebuilding CI Docker images #2077

Merged
merged 7 commits into from
Jan 8, 2025

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Dec 23, 2024

  • Update Intel SDE from 9.21.1 to 9.44.0 as the older version is no longer available on at the mirror location.
  • Update the AL2023 SSM Agent file to pull the changed path location for the manifest for GitHub.
  • Update the CentOS 7 docker image's mirrors to use the vault location as the previous mirror is no longer serving the repository files.
  • Since cryptofuzz is no longer available on GitHub from the original upstream author, update it to pull an archived file from a CloudFront distribution from our team AWS account. I have also put a copy of the code in AWS CodeCommit for a complete git history.
  • Botan repository tip isn't building for us on AL2023 anymore (looks like C++ 20 related / issues with cryptofuzz maybe?), anyways pinned to the current cryptofuzz we've been using and botan version that was released around that time.
  • Update CDK dependencies for good hygiene
  • Turns out our Windows CDK image build was never truly automated....so fix that by automating the long-standing issue of not installing the Docker engine.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@skmcgrail skmcgrail requested a review from a team as a code owner December 23, 2024 16:14
@skmcgrail skmcgrail changed the title Fixes Various Issues with rebuilding CI Docker images Fixes varios issues with rebuilding CI Docker images Dec 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (a16c659) to head (856cee3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2077      +/-   ##
==========================================
- Coverage   78.77%   78.76%   -0.02%     
==========================================
  Files         598      598              
  Lines      103744   103650      -94     
  Branches    14735    14720      -15     
==========================================
- Hits        81726    81640      -86     
+ Misses      21366    21357       -9     
- Partials      652      653       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

device_name="/dev/sda1", volume=block_device_volume
)

setup_user_data = ec2.UserData.for_windows()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any gotchas or things to know about "user data"? This seems like something really useful I could steal for the ec2 test framework.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the biggest gotcha is that the script are only ran on the first instance launch. So if you stop the instance, update the data, and start the instance again they won't automatically run. https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/user-data.html has more details.

@skmcgrail skmcgrail merged commit 3cea179 into aws:main Jan 8, 2025
122 of 125 checks passed
@skmcgrail skmcgrail deleted the rawr-ci branch January 8, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants