-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes varios issues with rebuilding CI Docker images #2077
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2077 +/- ##
==========================================
- Coverage 78.77% 78.76% -0.02%
==========================================
Files 598 598
Lines 103744 103650 -94
Branches 14735 14720 -15
==========================================
- Hits 81726 81640 -86
+ Misses 21366 21357 -9
- Partials 652 653 +1 ☔ View full report in Codecov by Sentry. |
device_name="/dev/sda1", volume=block_device_volume | ||
) | ||
|
||
setup_user_data = ec2.UserData.for_windows() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any gotchas or things to know about "user data"? This seems like something really useful I could steal for the ec2 test framework.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the biggest gotcha is that the script are only ran on the first instance launch. So if you stop the instance, update the data, and start the instance again they won't automatically run. https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/user-data.html has more details.
9.21.1
to9.44.0
as the older version is no longer available on at the mirror location.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.