Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize arrays as arrays #2042

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Initialize arrays as arrays #2042

merged 1 commit into from
Dec 9, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Dec 9, 2024

Issues:

Addresses aws/aws-lc-rs#623

Description of changes:

  • The size for arrays initialized with string literals should include the null-terminator. The arrays should instead be initialized like arrays are chars.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth marked this pull request as ready for review December 9, 2024 15:38
@justsmth justsmth requested a review from a team as a code owner December 9, 2024 15:38
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.67%. Comparing base (d681431) to head (434ec91).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2042      +/-   ##
==========================================
- Coverage   78.68%   78.67%   -0.02%     
==========================================
  Files         598      598              
  Lines      103350   103350              
  Branches    14692    14692              
==========================================
- Hits        81321    81308      -13     
- Misses      21377    21388      +11     
- Partials      652      654       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth requested a review from skmcgrail December 9, 2024 17:04
@justsmth justsmth merged commit 78c2583 into aws:main Dec 9, 2024
120 of 124 checks passed
@justsmth justsmth deleted the str-array-sizes branch December 9, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants