Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate recently added PKCS7 functions #2039

Merged

Conversation

WillChilds-Klein
Copy link
Contributor

@WillChilds-Klein WillChilds-Klein commented Dec 9, 2024

Description of changes:

This small PR deprecates all recently added PKCS7 functions and moves them to the appropriate section(s) in pkcs7.h. We also consolidate OPENSSL_BEGIN_ALLOW_DEPRECATED/OPENSSL_END_ALLOW_DEPRECATED directives in relevant source files.

Testing:

  • CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (b99aa7f) to head (d047fc1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2039   +/-   ##
=======================================
  Coverage   78.75%   78.76%           
=======================================
  Files         598      598           
  Lines      103620   103621    +1     
  Branches    14735    14736    +1     
=======================================
+ Hits        81606    81616   +10     
+ Misses      21361    21354    -7     
+ Partials      653      651    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WillChilds-Klein WillChilds-Klein force-pushed the pkcs7-deprecate-recent-additions branch from 995896e to d047fc1 Compare December 9, 2024 17:59
@WillChilds-Klein WillChilds-Klein marked this pull request as ready for review December 9, 2024 18:15
@WillChilds-Klein WillChilds-Klein requested a review from a team as a code owner December 9, 2024 18:15
justsmth
justsmth previously approved these changes Dec 9, 2024
crypto/pkcs7/pkcs7_test.cc Outdated Show resolved Hide resolved
samuel40791765
samuel40791765 previously approved these changes Dec 9, 2024
@WillChilds-Klein WillChilds-Klein merged commit b649c44 into aws:main Dec 9, 2024
119 of 124 checks passed
@WillChilds-Klein WillChilds-Klein deleted the pkcs7-deprecate-recent-additions branch December 9, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants