Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build on Solaris #2035

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Allow build on Solaris #2035

merged 1 commit into from
Dec 9, 2024

Conversation

psumbera
Copy link
Contributor

@psumbera psumbera commented Dec 5, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth
Copy link
Contributor

justsmth commented Dec 5, 2024

Here's the related PR that added host support for illumos: #1854

@justsmth
Copy link
Contributor

justsmth commented Dec 5, 2024

Hello @psumbera! Thanks for the PR.

In order for us to accept this contribution, we ask that you update the PR description to (at least) contain the following text about its licensing:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.67%. Comparing base (4dbc48d) to head (771705b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2035      +/-   ##
==========================================
- Coverage   78.68%   78.67%   -0.02%     
==========================================
  Files         598      598              
  Lines      103347   103347              
  Branches    14691    14692       +1     
==========================================
- Hits        81319    81304      -15     
- Misses      21375    21391      +16     
+ Partials      653      652       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psumbera
Copy link
Contributor Author

psumbera commented Dec 5, 2024

Hello @psumbera! Thanks for the PR.

In order for us to accept this contribution, we ask that you update the PR description to (at least) contain the following text about its licensing:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

Updated.

@justsmth justsmth merged commit e0214ba into aws:main Dec 9, 2024
120 of 122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants