Fix CI issues with ML-DSA #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torben-hansen
approved these changes
Dec 4, 2024
| const uint8_t *sig, size_t sig_len, | ||
| const uint8_t *message, size_t message_len, | ||
| const uint8_t *pre, size_t pre_len); | ||
| OPENSSL_EXPORT int ml_dsa_44_keypair(uint8_t *public_key, |
There was a problem hiding this comment.
These don't technically need it. but maybe they will later.
andrewhop
approved these changes
Dec 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2031 +/- ##
==========================================
+ Coverage 78.65% 78.67% +0.02%
==========================================
Files 598 598
Lines 103329 103329
Branches 14688 14687 -1
==========================================
+ Hits 81272 81298 +26
+ Misses 21404 21379 -25
+ Partials 653 652 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves CI failures with ML-DSA
Description of changes:
Added
OPENSSL_EXPORTto the problematic functions.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.