-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable UBE backends and move out of module #2022
Merged
torben-hansen
merged 18 commits into
aws:randomness_generation
from
torben-hansen:ube_active_and_tests
Dec 12, 2024
Merged
Enable UBE backends and move out of module #2022
torben-hansen
merged 18 commits into
aws:randomness_generation
from
torben-hansen:ube_active_and_tests
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## randomness_generation #2022 +/- ##
=========================================================
- Coverage 78.74% 78.71% -0.03%
=========================================================
Files 605 606 +1
Lines 102682 102759 +77
Branches 14563 14577 +14
=========================================================
+ Hits 80859 80889 +30
- Misses 21123 21160 +37
- Partials 700 710 +10 ☔ View full report in Codecov by Sentry. |
skmcgrail
reviewed
Dec 3, 2024
skmcgrail
reviewed
Dec 4, 2024
skmcgrail
reviewed
Dec 4, 2024
andrewhop
reviewed
Dec 9, 2024
skmcgrail
previously approved these changes
Dec 10, 2024
andrewhop
reviewed
Dec 10, 2024
andrewhop
reviewed
Dec 11, 2024
andrewhop
approved these changes
Dec 11, 2024
skmcgrail
approved these changes
Dec 12, 2024
torben-hansen
merged commit Dec 12, 2024
2459c63
into
aws:randomness_generation
104 of 116 checks passed
torben-hansen
added a commit
to torben-hansen/aws-lc
that referenced
this pull request
Dec 13, 2024
This change does a few things. Firstly, adds real UBE backend detection methods. In practice, just hooks up the existing ones to the appropriate UBE wrappers. Secondly, it moves those detection method implementations out of the FIPS module. There is no need to have them there and we can therefore also remove the delocateness from those implementations. Thirdly, implements more concurrent testing and adding more test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change does a few things. Firstly, adds real UBE backend detection methods. In practice, just hooks up the existing ones to the appropriate UBE wrappers. Secondly, it moves those detection method implementations out of the FIPS module. There is no need to have them there and we can therefore also remove the delocateness from those implementations. Thirdly, implements more concurrent testing and adding more test cases.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.