Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable UBE backends and move out of module #2022

Merged

Conversation

torben-hansen
Copy link
Contributor

@torben-hansen torben-hansen commented Nov 29, 2024

Description of changes:

This change does a few things. Firstly, adds real UBE backend detection methods. In practice, just hooks up the existing ones to the appropriate UBE wrappers. Secondly, it moves those detection method implementations out of the FIPS module. There is no need to have them there and we can therefore also remove the delocateness from those implementations. Thirdly, implements more concurrent testing and adding more test cases.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 67.77778% with 58 lines in your changes missing coverage. Please review.

Project coverage is 78.71%. Comparing base (8d54d64) to head (4c16c39).

Files with missing lines Patch % Lines
crypto/fipsmodule/rand/new_rand_test.cc 30.76% 16 Missing and 2 partials ⚠️
crypto/test/test_util.cc 40.00% 12 Missing and 6 partials ⚠️
crypto/ube/snapsafe_detect.c 47.05% 9 Missing ⚠️
crypto/ube/fork_detect.c 77.77% 6 Missing ⚠️
crypto/ube/ube_test.cc 88.88% 3 Missing and 1 partial ⚠️
crypto/ube/ube.c 93.54% 2 Missing ⚠️
crypto/test/ube_test.h 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           randomness_generation    #2022      +/-   ##
=========================================================
- Coverage                  78.74%   78.71%   -0.03%     
=========================================================
  Files                        605      606       +1     
  Lines                     102682   102759      +77     
  Branches                   14563    14577      +14     
=========================================================
+ Hits                       80859    80889      +30     
- Misses                     21123    21160      +37     
- Partials                     700      710      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@torben-hansen torben-hansen marked this pull request as ready for review December 2, 2024 18:39
@torben-hansen torben-hansen requested a review from a team as a code owner December 2, 2024 18:39
@torben-hansen torben-hansen enabled auto-merge (squash) December 4, 2024 16:50
crypto/ube/fork_detect.c Outdated Show resolved Hide resolved
crypto/fipsmodule/rand/new_rand_test.cc Show resolved Hide resolved
crypto/fipsmodule/rand/new_rand_test.cc Outdated Show resolved Hide resolved
crypto/ube/ube_test.cc Show resolved Hide resolved
crypto/ube/fork_detect.c Show resolved Hide resolved
crypto/ube/snapsafe_detect.c Outdated Show resolved Hide resolved
crypto/ube/ube_test.cc Outdated Show resolved Hide resolved
crypto/ube/ube_test.cc Outdated Show resolved Hide resolved
crypto/ube/ube_test.cc Outdated Show resolved Hide resolved
crypto/fipsmodule/rand/new_rand_test.cc Outdated Show resolved Hide resolved
skmcgrail
skmcgrail previously approved these changes Dec 10, 2024
crypto/ube/ube_test.cc Outdated Show resolved Hide resolved
crypto/ube/ube_test.cc Outdated Show resolved Hide resolved
crypto/ube/ube_test.cc Outdated Show resolved Hide resolved
crypto/ube/ube_test.cc Show resolved Hide resolved
crypto/ube/ube_test.cc Show resolved Hide resolved
crypto/ube/ube_test.cc Outdated Show resolved Hide resolved
@torben-hansen torben-hansen merged commit 2459c63 into aws:randomness_generation Dec 12, 2024
104 of 116 checks passed
torben-hansen added a commit to torben-hansen/aws-lc that referenced this pull request Dec 13, 2024
This change does a few things. Firstly, adds real UBE backend detection methods. In practice, just hooks up the existing ones to the appropriate UBE wrappers. Secondly, it moves those detection method implementations out of the FIPS module. There is no need to have them there and we can therefore also remove the delocateness from those implementations. Thirdly, implements more concurrent testing and adding more test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants