Move SSL_CIPHER_get_version test to SSLVersionTest.Version #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@adrewhop noticed that this test didn't cover TLSv1.3 although we'd expected it to. This is because the previous test case [guarded against TLSv1.3][1] for unrelated reasons. So, we move the test to another case that does cover TLSv1.3. [1]: https://github.com/aws/aws-lc/blob/main/ssl/ssl_test.cc#L7786-L7789
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1631 +/- ##
==========================================
+ Coverage 78.08% 78.10% +0.01%
==========================================
Files 562 562
Lines 94666 94666
Branches 13574 13575 +1
==========================================
+ Hits 73923 73935 +12
+ Misses 20150 20138 -12
Partials 593 593 ☔ View full report in Codecov by Sentry. |
andrewhop
approved these changes
Jun 10, 2024
justsmth
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves n/a (not needed for v1.29.0 release)
Addresses n/a
Description of changes:
@andrewhop noticed that this test didn't cover TLSv1.3 although we'd expected it to. This is because the previous test case guards against TLSv1.3 for unrelated reasons. So, we move the test to another case that does cover TLSv1.3.
Call-outs:
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.