Fix AES key size for AES256 in ABI test #1629
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves V1401987253
Description of changes:
This key buffer is too small for the larger key sizes that the test uses.
Call-outs:
It might be worth adding a address sanitizer + ABI test dimension. So far we haven't hit this before so I didn't add a new docker image with everything installed for that.
Testing:
Ran locally and manually reviewed the change for memory safety.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.