Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AES key size for AES256 in ABI test #1629

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

andrewhop
Copy link
Contributor

Issues:

Resolves V1401987253

Description of changes:

This key buffer is too small for the larger key sizes that the test uses.

Call-outs:

It might be worth adding a address sanitizer + ABI test dimension. So far we haven't hit this before so I didn't add a new docker image with everything installed for that.

Testing:

Ran locally and manually reviewed the change for memory safety.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@andrewhop andrewhop requested a review from a team as a code owner June 8, 2024 02:39
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.08%. Comparing base (e587bb5) to head (558d42a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1629      +/-   ##
==========================================
- Coverage   78.09%   78.08%   -0.01%     
==========================================
  Files         562      562              
  Lines       94656    94666      +10     
  Branches    13574    13573       -1     
==========================================
+ Hits        73923    73924       +1     
- Misses      20140    20146       +6     
- Partials      593      596       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewhop andrewhop merged commit bbfb3b2 into aws:main Jun 11, 2024
95 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants