Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove special aarch64 valgrind logic #1618

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Remove special aarch64 valgrind logic #1618

merged 1 commit into from
Jun 3, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Jun 3, 2024

Issues:

Resolves #P132890850

Description of changes:

  • Fix Valgrind test. The constants to configure static CPU capabilities on aarch64 are no longer needed.

Testing:

  • Tested on Ubuntu 24.04 and Amazon Linux 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth changed the title [DRAFT] Remove special aarch64 valgrind logic Remove special aarch64 valgrind logic Jun 3, 2024
@justsmth justsmth marked this pull request as ready for review June 3, 2024 17:03
@justsmth justsmth requested a review from a team as a code owner June 3, 2024 17:03
@justsmth justsmth requested a review from nebeid June 3, 2024 17:12
nebeid
nebeid approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@nebeid nebeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reverts only the part related static capabilities setting in 4edaef5.
The original issue for which this was needed, seems to have been remedied by 24cb055.
It also seems that Valgrind no longer chokes on SHA512 (assuming this PR was tested on Graviton3).

@justsmth justsmth merged commit bb40826 into aws:main Jun 3, 2024
89 of 92 checks passed
@justsmth justsmth deleted the fix-aarch64-valgrind branch June 3, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebeid nebeid nebeid approved these changes

@samuel40791765 samuel40791765 samuel40791765 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justsmth @samuel40791765 @nebeid