Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup EVP_PKEY serialization #669

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Jan 22, 2025

Description of changes:

  • Remove duplicated logic around usage of EVP_marshal_private_key, EVP_parse_private_key, EVP_marshal_public_key and EVP_parse_public_key.
  • Change all usage of EC_GROUP* to const.
  • Consolidate EC SEC1 and RFC 5915 parsing/marshaling into ec:encoding module.

Call-outs:

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 75.85227% with 85 lines in your changes missing coverage. Please review.

Project coverage is 92.97%. Comparing base (c358484) to head (e484aef).
Report is 158 commits behind head on main.

Files with missing lines Patch % Lines
aws-lc-rs/src/ec/encoding.rs 80.32% 14 Missing and 22 partials ⚠️
aws-lc-rs/src/agreement.rs 56.00% 4 Missing and 7 partials ⚠️
aws-lc-rs/src/ec/key_pair.rs 33.33% 1 Missing and 7 partials ⚠️
aws-lc-rs/src/ed25519.rs 27.27% 0 Missing and 8 partials ⚠️
aws-lc-rs/src/evp_pkey.rs 92.42% 5 Missing ⚠️
aws-lc-rs/src/ec/signature.rs 33.33% 0 Missing and 4 partials ⚠️
aws-lc-rs/src/rsa/key.rs 60.00% 0 Missing and 4 partials ⚠️
aws-lc-rs/src/ec.rs 70.00% 3 Missing ⚠️
aws-lc-rs/src/rsa/encoding.rs 50.00% 0 Missing and 2 partials ⚠️
aws-lc-rs/src/rsa/encryption.rs 77.77% 0 Missing and 2 partials ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
- Coverage   95.80%   92.97%   -2.83%     
==========================================
  Files          61       69       +8     
  Lines        8143     9593    +1450     
  Branches        0     9593    +9593     
==========================================
+ Hits         7801     8919    +1118     
- Misses        342      401      +59     
- Partials        0      273     +273     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth force-pushed the cleanup-serialization branch 2 times, most recently from cf7cead to d22622c Compare January 23, 2025 19:33
@justsmth justsmth force-pushed the cleanup-serialization branch from d22622c to eca53dc Compare January 23, 2025 19:36
@justsmth justsmth changed the title [DRAFT} Cleanup EVP_PKEY serialization [DRAFT] Cleanup EVP_PKEY serialization Jan 23, 2025
@justsmth justsmth changed the title [DRAFT] Cleanup EVP_PKEY serialization Cleanup EVP_PKEY serialization Jan 23, 2025
@justsmth justsmth marked this pull request as ready for review January 23, 2025 19:45
@justsmth justsmth requested a review from a team as a code owner January 23, 2025 19:45
@justsmth justsmth force-pushed the cleanup-serialization branch from eca53dc to 7141306 Compare January 24, 2025 16:36
@justsmth justsmth requested a review from skmcgrail January 24, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants