Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FIPS build w/ CPU Jitter #657

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

justsmth
Copy link
Contributor

Issues:

Addresses: CryptoAlg-2814

Description of changes:

  • Detects environment variable AWS_LC_FIPS_SYS_CPU_JITTER_ENTROPY indicating that AWS-LC should be built to use cpu jitter entropy.
  • Adds functions to allow consumers to verify cpu jitter entropy is in use at runtime.

Call-outs:

Testing:

  • Added script/CI that verifies that the fips_cpu_jitter_entropy() assertion succeeds.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner January 13, 2025 19:20
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Project coverage is 92.84%. Comparing base (c358484) to head (9c48333).
Report is 150 commits behind head on main.

Files with missing lines Patch % Lines
aws-lc-rs/src/lib.rs 73.07% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
- Coverage   95.80%   92.84%   -2.96%     
==========================================
  Files          61       68       +7     
  Lines        8143     9743    +1600     
  Branches        0     9743    +9743     
==========================================
+ Hits         7801     9046    +1245     
- Misses        342      407      +65     
- Partials        0      290     +290     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth requested a review from andrewhop January 15, 2025 18:59
@justsmth justsmth merged commit bcf56a3 into aws:main Jan 16, 2025
257 of 262 checks passed
@justsmth justsmth deleted the fips-cpu-jitter branch January 16, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants