Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message when repo submods not initialized #647

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Jan 6, 2025

Description of changes:

Improve messaging when a contributor clones our repo but doesn't initialize the submodules prior to a build.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner January 6, 2025 17:03
skmcgrail
skmcgrail previously approved these changes Jan 8, 2025
Copy link

@WillChilds-Klein WillChilds-Klein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giving the user the proper command to run might be a minor upgrade here. ACCP does this.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (c358484) to head (8acd16d).
Report is 145 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
- Coverage   95.80%   92.89%   -2.91%     
==========================================
  Files          61       67       +6     
  Lines        8143     9718    +1575     
  Branches        0     9718    +9718     
==========================================
+ Hits         7801     9028    +1227     
- Misses        342      402      +60     
- Partials        0      288     +288     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth merged commit 2d48ab5 into aws:main Jan 9, 2025
261 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants