Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new s2n-bignum symbols to filter #640

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

justsmth
Copy link
Contributor

Description of changes:

  • Filter our symbols recently added to s2n-bignum.

Testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@@ -20,7 +20,7 @@ function cmake_build_options() {
}

function filter_symbols() {
grep -v "^_\?bignum_" | grep -v "_\?curve25519_x25519" | grep -v "_\?edwards25519_" | grep -v "_\?p256_montj" | grep -v "_\?p384_montj" | grep -v "_\?p521_montj" | grep -v "_\?p521_jdouble"
grep -v "^_\?bignum_" | grep -v "_\?curve25519_x25519" | grep -v "_\?edwards25519_" | grep -v "_\?p256_montj" | grep -v "_\?p384_montj" | grep -v "_\?p521_montj" | grep -v "_\?p521_j"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be able to delete this script once we update the CI job here: aws/aws-lc#2073

@justsmth justsmth removed the request for review from WillChilds-Klein December 20, 2024 16:35
@justsmth justsmth merged commit 0470373 into aws:main Dec 20, 2024
258 of 259 checks passed
@justsmth justsmth deleted the fix-symbol-filter branch December 20, 2024 17:11
justsmth added a commit to justsmth/aws-lc-rs that referenced this pull request Dec 20, 2024
justsmth added a commit to aws/aws-lc that referenced this pull request Dec 20, 2024
### Description of changes: 
* Update the aws-lc-rs bindings generation CI check.

### Call-outs:
* Depends on: aws/aws-lc-rs#640

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants