Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AES 192 #622

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Support for AES 192 #622

merged 7 commits into from
Dec 13, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Dec 5, 2024

Issues:

Addresses: CryptoAlg-2678

Description of changes:

Add support for AES-192:

  • aead::AES_192_GCM
  • cipher::AES_192: CTR, CBC, ECB and CFB modes

Testing:

  • The AES_192_GCM tests use the NIST KATs
  • For cipher, test KAT values obtained from invoking same operation in OpenSSL.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from skmcgrail December 5, 2024 20:41
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 10 lines in your changes missing coverage. Please review.

Project coverage is 92.77%. Comparing base (c358484) to head (ef727c3).
Report is 127 commits behind head on main.

Files with missing lines Patch % Lines
aws-lc-rs/src/cipher/key.rs 76.47% 5 Missing and 3 partials ⚠️
aws-lc-rs/src/aead/quic.rs 66.66% 1 Missing ⚠️
aws-lc-rs/src/aead/unbound_key.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
- Coverage   95.80%   92.77%   -3.03%     
==========================================
  Files          61       67       +6     
  Lines        8143     9879    +1736     
  Branches        0     9879    +9879     
==========================================
+ Hits         7801     9165    +1364     
- Misses        342      428      +86     
- Partials        0      286     +286     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth force-pushed the aes-192 branch 2 times, most recently from 00d9783 to 9387a23 Compare December 5, 2024 21:47
@justsmth justsmth marked this pull request as ready for review December 6, 2024 15:17
@justsmth justsmth requested a review from a team as a code owner December 6, 2024 15:17
aws-lc-rs/src/cipher.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@samuel40791765 samuel40791765 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; double checked that we weren't exposing AES-192 for TLS since there aren't any existing ciphers using it.

@justsmth justsmth merged commit c75bc5c into aws:main Dec 13, 2024
256 checks passed
@justsmth justsmth deleted the aes-192 branch December 13, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants