-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for AES 192 #622
Support for AES 192 #622
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
==========================================
- Coverage 95.80% 92.77% -3.03%
==========================================
Files 61 67 +6
Lines 8143 9879 +1736
Branches 0 9879 +9879
==========================================
+ Hits 7801 9165 +1364
- Misses 342 428 +86
- Partials 0 286 +286 ☔ View full report in Codecov by Sentry. |
00d9783
to
9387a23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; double checked that we weren't exposing AES-192 for TLS since there aren't any existing ciphers using it.
Issues:
Addresses: CryptoAlg-2678
Description of changes:
Add support for AES-192:
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.