Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to configure TCP keep alive when updating MQTT keep alive time #1896

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

tony-josi-aws
Copy link
Member

While updating the MQTT keep alive time beyond certain value which is above the TCP keep alive time the underlying TCP connection is assumed dead depending on the cofiguration and this causes the device disconnection to go undetected.

This PR updates the readme with instructions to configure TCP keep alive when updating MQTT keep alive time.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@tony-josi-aws tony-josi-aws requested a review from a team as a code owner November 7, 2023 07:00
demos/readme.md Outdated Show resolved Hide resolved
Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]>
aggarg
aggarg previously approved these changes Nov 20, 2023
ActoryOu
ActoryOu previously approved these changes Nov 20, 2023
Copy link
Member

@ActoryOu ActoryOu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it's good enough. Approve in advance. Some indents are not aligned with code. It'd be great to align that.

@tony-josi-aws tony-josi-aws dismissed stale reviews from ActoryOu and aggarg via 7a3948e November 20, 2023 09:08
@ActoryOu ActoryOu merged commit 14e27df into aws:main Nov 20, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants