AWS for Fluent Bit 2.32.3 with Input Grace period fix #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wesley Pettit <[email protected]>
PettitWesley
commented
May 31, 2024
| * Amazon Kinesis Firehose for Fluent Bit 1.7.2 | ||
|
|
||
| Compared to `2.31.12` this release adds: | ||
| * Fix - During shutdown, the `Grace` setting controls how long Fluent Bit waits after receiving a SIGTERM before exiting. Previously, input ingestion was paused one second after shutdown; with this change Fluent Bit stops acceptings new logs when one half of the `Grace` period time has elapsed. |
There was a problem hiding this comment.
also set default grace to 30
and check buffers on shutdown
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
|
@everhardt We've made some changes to our deployment process that invalidate the specific code in this change, which is why we closed the PR. Separately, this change requires more internal testing to confirm it solves the issue in all cases; there are some anomalies in that testing which we are currently looking into. We don't intend to publish the change until we've confirmed that it works properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Diff: https://github.com/PettitWesley/fluent-bit/pull/33/commits
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.