linux pipeline: auth to dockerhub before calling API #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PettitWesley
commented
Nov 8, 2022
| @@ -235,6 +243,8 @@ sync_latest_image() { | |||
| region=${1} | |||
| account_id=${2} | |||
|
|
|||
| get_latest_dockerhub_version ${region} | |||
There was a problem hiding this comment.
We can't call this function every time this script is used since it will require secrets manager permissions. So now we only call it when needed.
Signed-off-by: Wesley Pettit <[email protected]>
PettitWesley
force-pushed
the
auth-to-dockerhub
branch
from
c940ff3
to
663ddef
Compare
matthewfala
reviewed
Nov 8, 2022
| auth="Authorization: Bearer ${token}" | ||
| docker_hub_image_tags=$(curl -s -S -H "${auth}" 'https://registry.hub.docker.com/v2/repositories/amazon/aws-for-fluent-bit/tags/?page=1&page_size=250' | jq -r '.results[].name') | ||
| tag_array=(`echo ${docker_hub_image_tags}`) | ||
| AWS_FOR_FLUENT_BIT_VERSION_DOCKERHUB=$(./get_latest_dockerhub_version.py ${tag_array[@]}) |
There was a problem hiding this comment.
This script doesn't need to be authorized too, does it?
There was a problem hiding this comment.
Oh i see. It's just a parser. https://github.com/PettitWesley/aws-for-fluent-bit/blob/auth-to-dockerhub/scripts/get_latest_dockerhub_version.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wesley Pettit [email protected]
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.