release init images WITH stable tag #395
Conversation
|
Hold this PR until init stable version is available |
| @@ -122,6 +122,17 @@ publish_to_docker_hub() { | |||
| if [ "$IMAGE_SHA_MATCHED" = "FALSE" ]; then | |||
| create_manifest_list ${1} "stable" ${AWS_FOR_FLUENT_BIT_STABLE_VERSION} | |||
| fi | |||
|
|
|||
| docker pull ${1}:"$init"-stable || echo "0" | |||
There was a problem hiding this comment.
hmmm either I didn't notice this before or I no longer remember why its :"$init"-stable shouldn't it just be init-stable...
There was a problem hiding this comment.
Hmm, let me recall...
I think I did this because we need to put different suffixes after "init" other than "stable".
Like here and here.
And sometimes we need to use "init stable" rather than "init-stable" like here.
Due to the different code styles and parameter passing way in this file so I chose not to hard code "init".
There was a problem hiding this comment.
Thank you @Galaoaoa for showing strong ownership and continuing to track this PR :)
I think I did this because we need to put different suffixes after "init" other than "stable".
Hmm but I don't understand why we need the "$init"... the init part never changes right? Its the bit afterwards. So I'd expect to see: init-${var}.
There was a problem hiding this comment.
Yeah, we can use init instead of "$init". From the current perspective, I think we could indeed just use the init, this would be the better way :)
| @@ -302,6 +327,8 @@ sync_latest_image() { | |||
| fi | |||
| create_manifest_list ${account_id}.dkr.ecr.${region}.${endpoint}/aws-for-fluent-bit "stable" ${AWS_FOR_FLUENT_BIT_STABLE_VERSION} || echo "0" | |||
|
|
|||
| create_manifest_list_init ${account_id}.dkr.ecr.${region}.${endpoint}/aws-for-fluent-bit "init-stable" ${AWS_FOR_FLUENT_BIT_STABLE_VERSION} || echo "0" | |||
There was a problem hiding this comment.
This code has changed: #571 (comment)
Changes
Modify the Pipeline and Sync stack, 10 images will be release as the same time after merge.
e.g. latest version: 2.27.0, stable version 2.26.5, will release:
aws-for-fluent-bit:amd64-2.27.0aws-for-fluent-bit:arm64-2.27.0aws-for-fluent-bit:2.27.0aws-for-fluent-bit:latestaws-for-fluent-bit:stableaws-for-fluent-bit:init-amd64-2.27.0aws-for-fluent-bit:init-arm64-2.27.0aws-for-fluent-bit:init-2.27.0aws-for-fluent-bit:init-latestaws-for-fluent-bit:init-stableImportant Node:
Because currently we don't have the stable version for init image. So please merge this PR after we have a stable version of Init image