Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update for latest MPL and smithy-dafny #696

Merged
merged 7 commits into from
Nov 15, 2024

Conversation

ajewellamz
Copy link
Contributor

Issue #, if available:

Description of changes:

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ajewellamz ajewellamz requested a review from a team as a code owner November 15, 2024 15:01
@ajewellamz ajewellamz changed the base branch from mainline to rkapila/rust-reviewed November 15, 2024 15:02
@ajewellamz ajewellamz changed the title Ajewell/rust smithy update chore: update for latest MPL and smithy-dafny Nov 15, 2024
Copy link
Contributor

@RitvikKapila RitvikKapila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

Since you created a main.rs file for TestVectors, can you also remove Line#93-99 and 111 and 122-123 from the TestVectors Makefile?

Copy link
Contributor

@RitvikKapila RitvikKapila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajewellamz ajewellamz merged commit 63256e3 into rkapila/rust-reviewed Nov 15, 2024
47 checks passed
@ajewellamz ajewellamz deleted the ajewell/rust-smithy-update branch November 15, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants