Bump the ceiling for botocore memory leak tests to 15 MiB #8744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See boto/botocore#3205 for the background on this. In rebuilding awscli2 for Python 3.13 in Fedora Rawhide, we found that two of these tests fail because they now top out around 11MiB of memory usage, rather than around 1.6MiB. We don't understand why this is yet, but it's not a memory *leak*, so bumping the ceiling seems appropriate. I'm sending this upstream so I have a reference for the downstream package and to raise awareness of the issue, but the correct fix may be something else. Signed-off-by: Adam Williamson <[email protected]>
|
Thanks for this PR — I just commented on the issue you opened providing more context. After discussing with the team we decided to close this PR as more research is required into the underlying issue, but please refer to boto/botocore#3185 for further discussion around memory usage and testing in Python 3.13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
See boto/botocore#3205 for the background on this. In rebuilding awscli2 for Python 3.13 in Fedora Rawhide, we found that two of these tests fail because they now top out around 11MiB of memory usage, rather than around 1.6MiB. We don't understand why this is yet, but it's not a memory leak, so bumping the ceiling seems appropriate. I'm sending this upstream so I have a reference for the downstream package and to raise awareness of the issue, but the correct fix may be something else.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.