feat(ecs): machineImageType support AL2023 #32509
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
effort/small
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32509 +/- ##
=======================================
Coverage 78.66% 78.66%
=======================================
Files 107 107
Lines 7161 7161
Branches 1320 1320
=======================================
Hits 5633 5633
Misses 1343 1343
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
GavinZZ
requested changes
Dec 13, 2024
Comment on lines
+633
to
+635
| case MachineImageType.AMAZON_LINUX_2023: { | ||
| autoScalingGroup.addUserData('sudo iptables-save'); | ||
| break; |
There was a problem hiding this comment.
Can you confirm for AL2023, the old command sudo service iptables save doesn't work to make sure this is not a breaking change?
There was a problem hiding this comment.
Thanks for your review @GavinZZ. This is the old command on latest ECS optimized AL2023 ami-0a357ea20d7b79c2c
aws-cdk-automation
removed
the
pr/needs-community-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #32496
Relate #32469
Reason for this change
Description of changes
machineImageTypesupport AL2023Description of how you validated changes
Unit + Integration test
Instance can join cluster
iptables command success
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license