Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs): userdata iptables command on AL2 #32495

Closed
wants to merge 5 commits into from

Conversation

phuhung273
Copy link
Contributor

@phuhung273 phuhung273 commented Dec 12, 2024

Issue # (if applicable)

Closes #32469

Reason for this change

  • invalid iptables command on AL2

Description of changes

  • AL2: sudo service iptables save > sudo iptables-save

Description of how you validated changes

yarn integ --directory test/aws-ecs/test --update-on-failed

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Dec 12, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 12, 2024 04:09
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.60%. Comparing base (5e73dd0) to head (3735b48).
Report is 49 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #32495      +/-   ##
==========================================
- Coverage   78.67%   78.60%   -0.08%     
==========================================
  Files         107      107              
  Lines        7237     7161      -76     
  Branches     1329     1320       -9     
==========================================
- Hits         5694     5629      -65     
+ Misses       1357     1347      -10     
+ Partials      186      185       -1     
Flag Coverage Δ
suite.unit 78.60% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.60% <ø> (-0.08%) ⬇️

@phuhung273 phuhung273 marked this pull request as ready for review December 12, 2024 06:03
@phuhung273
Copy link
Contributor Author

Exemption Request: all integration tests rerun

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Dec 12, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 12, 2024 13:00

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3735b48
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@phuhung273 phuhung273 marked this pull request as draft December 14, 2024 08:38
@phuhung273 phuhung273 closed this Dec 19, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2024
@phuhung273 phuhung273 deleted the fix-ecs-user-data branch December 24, 2024 02:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p1 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-ecs: appends invalid ecs user data
2 participants