Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dependency on in-source compilation of bin/ directory #32476

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Dec 11, 2024

The bin/cdk binary relies on the fact that bin/cdk.ts undergoes an in-source compilation, producing bin/cdk.js which is then required.

This fails in a different setup where we only compile the lib/ directory and nothing else.

So skip one level of indirection: just put the code that loads the actual CLI entry point directly in the bash wrapper.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The `bin/cdk` binary relies on the fact that `bin/cdk.ts` undergoes
an in-source compilation, producing `bin/cdk.js` which is then required.

This fails in a different setup where we only compile the `lib/`
directory and nothing else.

So skip one level of indirection: just put the code that loads the
actual CLI entry point directly in the bash wrapper.
@rix0rrr rix0rrr requested a review from a team December 11, 2024 14:52
@github-actions github-actions bot added the p2 label Dec 11, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 11, 2024 14:52
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.60%. Comparing base (fe7d435) to head (63f447d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32476   +/-   ##
=======================================
  Coverage   78.60%   78.60%           
=======================================
  Files         107      107           
  Lines        7161     7161           
  Branches     1320     1320           
=======================================
  Hits         5629     5629           
  Misses       1347     1347           
  Partials      185      185           
Flag Coverage Δ
suite.unit 78.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.60% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 11, 2024
Copy link
Contributor

mergify bot commented Dec 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 11, 2024
Copy link
Contributor

mergify bot commented Dec 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Dec 11, 2024

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link
Contributor

mergify bot commented Dec 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 63f447d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6e28ffe into main Dec 12, 2024
17 of 18 checks passed
@mergify mergify bot deleted the huijbers/no-js-file branch December 12, 2024 11:47
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants