chore: enable log timestamps by default

[HBobertz]

Reason for this change

timestamps were no longer being printed for debug and trace level logging messages, because as part of the logging changes, I incidentally removed the timestamps from the debug() and trace() functions.

Description of changes

Re-added timestamps for whenever those 2 methods are called

i.e.

debug: "message"
is now
"[09:58:24] message"

info: "message"
is still
"message"

which was the previous functionality

Description of how you validated changes

Modified relevant unit tests and also did manual testing by verifying outputs of cdk commands on different cdk versions

# running cdk synth from local build of bobertzh/logging-fix
[15:08:06] CDK toolkit version: 0.0.0 (build 68b77e7)
[15:08:06] Command line arguments: {
... 
Resources:
  CDKMetadata:
...

# running cdk synth from live
CDK toolkit version: 2.173.0 (build b5c2189)
Command line arguments: {
...
Resources:
  CDKMetadata:
...

# running cdk synth from be000a251b781b0b0870930992793df5a2fc4b01 (parent commit)

[15:20:33] CDK toolkit version: 0.0.0 (build be000a2)
[15:20:33] Command line arguments: {
...
Resources:
  CDKMetadata:
...

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.66%. Comparing base (d14d784) to head (064dbdc).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #32448   +/-   ##
=======================================
  Coverage   78.66%   78.66%           
=======================================
  Files         107      107           
  Lines        7161     7161           
  Branches     1320     1320           
=======================================
  Hits         5633     5633           
  Misses       1343     1343           
  Partials      185      185           

Flag	Coverage Δ
suite.unit	78.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	78.66% <100.00%> (ø)

[mrgrain]

Please provide an example of the previous correct output and what the current failure is. The PR description doesn't explain why this change is made.

[HBobertz]

Please provide an example of the previous correct output and what the current failure is. The PR description doesn't explain why this change is made.

Yup will do, also noticed a bug however that this pr is printing out this log message in this format

[12:26:49] No stacks match the name(s) [12:25:56] stack-name

so I'm gonna fix that, and then update the ticket with that information

[aws-cdk-automation]

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/32448/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/32448/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 064dbdc
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository