chore: chalk breaking logging tests #32393
Conversation
HBobertz
changed the title
HBobertz
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
HBobertz
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
|
|
||
| describe('logging', () => { | ||
| // Mock streams to capture output | ||
| let mockStdout: jest.Mock; | ||
| let mockStderr: jest.Mock; | ||
|
|
||
| // Helper function to strip ANSI codes | ||
| const stripAnsi = (str: string): string => { |
There was a problem hiding this comment.
I have this function twice, I figure it's fine but if it's not DRY enough then I can put it in a helper function directory
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32393 +/- ##
==========================================
+ Coverage 78.66% 78.67% +0.01%
==========================================
Files 107 107
Lines 7237 7237
Branches 1329 1329
==========================================
+ Hits 5693 5694 +1
+ Misses 1358 1357 -1
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more.
|
HBobertz
changed the title
HBobertz
changed the title
HBobertz
changed the title
HBobertz
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: Pull request #32393 has been dequeued. The pull request rule doesn't match anymore. The pull request has been synchronized by a user.. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
HBobertz
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
logging tests would break when running
npx jestbut not when runningyarn testas npx jest was not pulling out the ansi codes which were failing the string comparisons.Description of changes
Removed all the ansi codes from stdout in logging and log-monitor tests
Description of how you validated changes
ran
npx jestandyarn testas well as rebuilt the packageChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license