-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dynamoDB): make TableV2 taggable #31867
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO I think this is an issue with the spec2cdk generation and something we should fix in the L1 generation instead of L2 side.
.../aws-dynamodb/test/integ.dynamodb-v2.ondemand.js.snapshot/aws-cdk-global-table.template.json
Outdated
Show resolved
Hide resolved
Thanks for addressing the other comments. I'm happy to approve once we check with the service team and update the documentation. |
Thanks for reviewing this! @GavinZZ, I'll follow up with the product team. |
15d8a27
to
4e2481e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
4e2481e
to
4adfb4d
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks good to me, I just left some minor comments.
Pull request has been modified.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #30631
Reason for this change
The
AWS::DynamoDB::GlobalTable
resource does not natively support tags. However, at the L2 level (TableV2
), thetags
option is available when creating this resource, which may give customers the impression that it is taggable. When customers apply tags using the aspect at theTableV2
level, it’s likely they intend to tag all replicas, as each replica has its owntags
property as well. This behavior also aligns with the related construct documentation.Description of changes
TableV2
tags
properties, it will take precedence over theTagAspect
for that key, as it is more specific.tags
property behavior inTableV2
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license