Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamoDB): make TableV2 taggable #31867

Merged
merged 9 commits into from
Nov 2, 2024
Merged

fix(dynamoDB): make TableV2 taggable #31867

merged 9 commits into from
Nov 2, 2024

Conversation

5d
Copy link
Member

@5d 5d commented Oct 23, 2024

Issue # (if applicable)

Closes #30631

Reason for this change

The AWS::DynamoDB::GlobalTable resource does not natively support tags. However, at the L2 level (TableV2), the tags option is available when creating this resource, which may give customers the impression that it is taggable. When customers apply tags using the aspect at the TableV2 level, it’s likely they intend to tag all replicas, as each replica has its own tags property as well. This behavior also aligns with the related construct documentation.

Description of changes

  • Enable tagging for TableV2
  • If a tag key is defined in the replica tags properties, it will take precedence over the TagAspect for that key, as it is more specific.
  • Keep the tags property behavior in TableV2
    • Update the description doc on it to reflect that it only applies to the default replica table

Description of how you validated changes

  • added new unit test cases
  • deployed related integration test cases

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 23, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 23, 2024 20:27
@github-actions github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Oct 23, 2024
@5d 5d changed the title fix(dynamoDB): add tags to TableV2 fix(dynamoDB): make TableV2 taggable Oct 23, 2024
@5d 5d marked this pull request as ready for review October 23, 2024 21:54
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 23, 2024
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort labels Oct 23, 2024
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO I think this is an issue with the spec2cdk generation and something we should fix in the L1 generation instead of L2 side.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 24, 2024
@GavinZZ
Copy link
Contributor

GavinZZ commented Oct 24, 2024

Thanks for addressing the other comments. I'm happy to approve once we check with the service team and update the documentation.

@5d
Copy link
Member Author

5d commented Oct 24, 2024

Thanks for addressing the other comments. I'm happy to approve once we check with the service team and update the documentation.

Thanks for reviewing this! @GavinZZ, I'll follow up with the product team.

@mergify mergify bot dismissed GavinZZ’s stale review October 29, 2024 19:21

Pull request has been modified.

@5d 5d force-pushed the 5d/fix-issue-30631 branch from 15d8a27 to 4e2481e Compare October 29, 2024 19:58
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@5d 5d force-pushed the 5d/fix-issue-30631 branch from 4e2481e to 4adfb4d Compare October 29, 2024 21:05
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 29, 2024 21:07

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 29, 2024
@5d 5d requested a review from GavinZZ October 29, 2024 21:48
Copy link
Contributor

@moelasmar moelasmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good to me, I just left some minor comments.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 31, 2024
@mergify mergify bot dismissed moelasmar’s stale review October 31, 2024 20:04

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 31, 2024
Copy link
Contributor

mergify bot commented Nov 2, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 2, 2024
Copy link
Contributor

mergify bot commented Nov 2, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4506d29
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 796c6d1 into main Nov 2, 2024
12 checks passed
Copy link
Contributor

mergify bot commented Nov 2, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the 5d/fix-issue-30631 branch November 2, 2024 03:39
Copy link

github-actions bot commented Nov 2, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(dynamodb): Dynamo TableV2 does not work with Tags.of
4 participants