-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stepfunctions-tasks): allow passing apiEndpoint as intrinsic function #31643
fix(stepfunctions-tasks): allow passing apiEndpoint as intrinsic function #31643
Conversation
…mic values in the path. Update README entry with more complex example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Clarification Request What is the process for updating integration tests? My previous attempts failed in CI due to snapshots not matching, which they shouldn't when the test changes. |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
Hi @MathieuGilbert, The instruction to create/update the integration tests is in here. I think we can just use integ.invoke.ts as the starting point and update line 68 to use |
…tpinvoke-format-apiendpoint
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Hi @MathieuGilbert, maybe I wasn't very clear before but this was what I meant. Although, like I have said, I am not able to run the test due to account restriction. And then I believe you need to run |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Comments on closed issues and PRs are hard for our team to see. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Issue #29925
Closes #29925, #30749.
Reason for this change
The
apiEndpoint
prop currently only works when it's a string (ie.TaskInput.fromText('some/text')
), with the task failing when passed as a reference (ie.TaskInput.fromText(JsonPath.format('some/text/{}', '123')
). This is needed to allow for dynamic parts in the path.Description of changes
ApiEndpoint
task parameter to use theJsonPath.format
intrinsic function to combine theapiRoot
andapiEndpoint
props, instead of basic string concatenation.Description of how you validated changes
GET /testing
with basic auth Connection and was successfully invoked with task and payload{ "endpointName: "testing" }
:Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license